[wasm64] Remove temporary toIndexType workaround #22773
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
remove_toIndexType
branch
from
30271f3 to
0dd9f78
Compare
dschuff
approved these changes
Oct 22, 2024
kripken
approved these changes
Oct 22, 2024
| function toIndexType(x) { | ||
| if (MEMORY64 != 1) return x; | ||
| return `toIndexType(${x})`; | ||
| return to64(x); |
Member
There was a problem hiding this comment.
Should we replace calls from toIndexType to to64? Or do we think the distinction is important/might matter later?
Member
There was a problem hiding this comment.
I lean towards keeping the distinction, but just a thought.
Collaborator
Author
There was a problem hiding this comment.
Yes, I thought of doing that. Can always be done as followup I guess?
Member
There was a problem hiding this comment.
Followup sounds fine, but also I am not sure if that is worthwhile. Unless we are certain we won't care about the difference later (which I am not sure of myself).
sbc100
force-pushed
the
remove_toIndexType
branch
from
0dd9f78 to
d239a63
Compare
sbc100
force-pushed
the
remove_toIndexType
branch
5 times, most recently
from
19669ae to
148a408
Compare
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Nov 1, 2024
This involved using toIndexType in a few more places due to recent wasm64 changes requiring BitInt in more places. Split out from emscripten-core#22773
Merged
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Nov 4, 2024
This involved using toIndexType in a few more places due to recent wasm64 changes requiring BitInt in more places. Split out from emscripten-core#22773
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Nov 4, 2024
This involved using toIndexType in a few more places due to recent wasm64 changes requiring BitInt in more places. Split out from emscripten-core#22773
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Nov 4, 2024
This involved using toIndexType in a few more places due to recent wasm64 changes requiring BitInt in more places. Split out from emscripten-core#22773
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Nov 4, 2024
This involved using toIndexType in a few more places due to recent wasm64 changes requiring BitInt in more places. Split out from emscripten-core#22773
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Nov 4, 2024
This involved using toIndexType in a few more places due to recent wasm64 changes requiring BitInt in more places. Split out from emscripten-core#22773
sbc100
force-pushed
the
remove_toIndexType
branch
from
148a408 to
13bcbe9
Compare
sbc100
added a commit
that referenced
this pull request
Nov 4, 2024
This involved using toIndexType in a few more places due to recent wasm64 changes requiring BitInt in more places. Split out from #22773
sbc100
force-pushed
the
remove_toIndexType
branch
2 times, most recently
from
1c7ab1b to
7b0634d
Compare
Now the firefox and chrome both use BigInt for indexing 64-bit memories and tables this workaround is no longer needed.
sbc100
force-pushed
the
remove_toIndexType
branch
from
7b0634d to
8685f1a
Compare
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Nov 5, 2024
sbc100
added a commit
that referenced
this pull request
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now the firefox and chrome both use BigInt for indexing 64-bit memories and tables this workaround is no longer needed.